Upload with tags with tag with a hyphen symbol creates multiple tags

[AevumDecessus]

Describe the bug If you tag a model in the upload dialog with a tag containing a hyphen character, it creates the tags as expected, but also creates a tag with the hyphen character replaced with a space character

To Reproduce Steps to reproduce the behavior:

1. Add models to the upload dialog
2. Tag the models, with at least one tag having a - symbol in it
3. Finish uploading the model

Expected behavior The model to be uploaded, and tagged as tagged in the upload dialog

Screenshots Tags in upload dialog

Tags applied to models

Additional context The double-sided tag in the upload dialog created a double-sided tag as expected, but also a double sided tag that is applied to most of the models

[AevumDecessus]

This is on the v0.79.0 linuxserver image

[Floppy]

Ooh! Interesting! Does it do the same thing in the general editing page?

[Floppy]

I checked; it doesn't.

[Floppy]

OK, I think I understand why this is happening. When the model is created, it's given the right set of tags, but when it's then scanned, and path template parsing is enabled, it will read the folder names back in and apply them as tags. That should normally be fine, because the folder was created because of the original tag, but in the case where there's a hyphen, the default folder-to-tag behaviour is to remove the hyphen when creating a tag.

This is because both of the tags hello-world and hello world will convert to hello-world on disk.

Hmmm. This has similar problems to capitalisation of tags and folder name safety, in #3735 and #3742.

[AevumDecessus]

good to know, makes sense now that you've explained it, fairly trivial to just avoid hyphens in tag names to not run into this