Manu Zhang
Manu Zhang
@darionyaphet have you verified whether integration tests pass for storm ?
@darionyaphet thanks for your contributions. please add license headers
@darionyaphet also please modify your commit comment to `fix GEARPUMP-106, Redis integration` which would make our pr merge script happier.
@darionyaphet yes, as we use jira now issue id should be GEARPUMP-XXX. You may our recent commits for examples
@darionyaphet Could you add this module to the **experiments** ? That will be low risk before the module is mature. Plus, the experiments doesn't require UT coverage. Also, please add...
@darionyaphet What's the difference between `RedisStorage` and `RedisSink` here since they both extend `DataSink` ?
@karol-brejna-i @darionyaphet I understand the difference between `RedisSink` and `RedisStorage` now but I don't think `RedisStorage` should extend the `DataSink` interface which is intended for write. Probably we need a...
@darionyaphet this is partially done in #93. Please rebase or, close and fire a new PR for follow-ups.
sorry, I was too optimistic previously. This example contains a cycle which cause the generation of process levels into dead loop. Please check https://github.com/apache/incubator-gearpump/blob/master/core/src/main/scala/io/gearpump/util/Graph.scala#L380