electronim icon indicating copy to clipboard operation
electronim copied to clipboard

Can't login to Office365/Teams

Open dionorgua opened this issue 5 years ago • 3 comments

Trying to add https://teams.microsoft.com/ tab. ElectronIM shows 'Checking your credentials...' in tab header, at the same time authentication page is opened in external browser. After login messenger is displayed in external browser too..

It think it's done such way to open random URL's in browser. But I think that some 'whitelist' or temporary disable of such behavior is needed.

dionorgua avatar Jan 13 '21 09:01 dionorgua

Hi, there's already some logic in place to deal with those situations: https://github.com/manusa/electronim/blob/dd9233b2ad2f0d5b81ed31e36d15c336ea7cbaf9/src/tab-manager/redirect.js

Adding a fix for teams should be possible

manusa avatar Jan 13 '21 10:01 manusa

Ah. Thanks. Will play with it a bit.

But I still think it's better to at least have such regexp list configurable by user.

It's pretty common to use some third-party oauth or 2fa authentications. In such case you'll have redirects like 'Teams -> Oauth -> Third-party -> Oauth -> Teams'.

dionorgua avatar Jan 13 '21 10:01 dionorgua

But I still think it's better to at least have such regexp list configurable by user.

That's a really good point, didn't actually consider that, but definitely something to implement.

Will probably go with a quick fix/default value for teams/Microsoft. Later on provide this configurable behavior in the settings interface.

manusa avatar Jan 13 '21 10:01 manusa