Marc Nuri comments

Results 829 comments of


                                            Marc Nuri

Removed mockito usage from test file

### Eclipse JKube [CI Report](https://github.com/eclipse-jkube/ci) Started new GH workflow run for https://github.com/eclipse-jkube/jkube/pull/3425 (_2024-10-03T17:52:05Z_) :gear: [JKube E2E Tests (11166853707)](https://github.com/eclipse-jkube/ci/actions/runs/11166853707) - :heavy_check_mark: [Bootstrap CI test run (#3425)](https://github.com/eclipse-jkube/ci/actions/runs/11166853707/job/31041736661) - :heavy_check_mark: [K8S v1.25.13 dockerfile...

Using property `jkube.enricher.jkube-name.name` overrides the names set in the resources fragments

We need to further discuss this to set the basic scenarios and user expectations. The suggested approach breaks the existing functionality to override a name via system property or CLI...

Container image build args can be overridden following their order of precedence

What's the reason for changing the order of precedence stated by Rohan in the description of the issue? I find it OK that project properties override system properties (although I'm...

As an user, I want to provide a `values.yaml` when the Helm Chart is generated

This can be done in a similar way, see the following demo project git-snapshot: https://github.com/marcnuri-demo/jkube-helm/tree/4dbcae55b51608a1aef5fd7ae6d0ba8ce8c580cb Although not exactly what you require, a `Template` can be provided to set some parameters:...

As an user, I want to provide a `values.yaml` when the Helm Chart is generated

OK, I'm more or less grasping your problem now. Support for arrays and maps is not yet here. So the first thing to note is that `parameters` is not the...

As an user, I want to provide a `values.yaml` when the Helm Chart is generated

> To be fair, even if there was such a syntax, I still think there is value to let user provide their own values.yaml file instead of having to make...

chore(deps): Bump org.codehaus.plexus:plexus-utils from 3.5.0 to 4.0.2

### Eclipse JKube [CI Report](https://github.com/eclipse-jkube/ci) Started new GH workflow run for https://github.com/eclipse-jkube/jkube/pull/3401 (_2024-09-24T23:25:10Z_) :gear: [JKube E2E Tests (11023436448)](https://github.com/eclipse-jkube/ci/actions/runs/11023436448) - :x: [Bootstrap CI test run (#3401)](https://github.com/eclipse-jkube/ci/actions/runs/11023436448/job/30614721243) - :x: [K8S ${{ matrix.kubernetes...

As an user, I want to generate a Helm Chart without any Kubernetes resource

Similar to #865

fix: changed to conventional Object.isEmpty() from Object.length()==0

### Eclipse JKube [CI Report](https://github.com/eclipse-jkube/ci) Started new GH workflow run for https://github.com/eclipse-jkube/jkube/pull/3215 (_2024-07-02T18:51:23Z_) :gear: [JKube E2E Tests (9766264277)](https://github.com/eclipse-jkube/ci/actions/runs/9766264277) - :heavy_check_mark: [Bootstrap CI test run (#3215)](https://github.com/eclipse-jkube/ci/actions/runs/9766264277/job/26958804506) - :heavy_check_mark: [K8S v1.25.13 dockerfile...

Changing the default port of the embedded server does not change the K8S probes default port

> Otherwise, if command `mvn package` is required before `mvn k8s:resource` then no bug is observed here, just need to update doc and close the issue. > > P.S. I...