Marc Nuri

Results 701 comments of Marc Nuri

### Eclipse JKube [CI Report](https://github.com/jkubeio/ci) Started new GH workflow run for https://github.com/eclipse/jkube/pull/1416 (_2022-06-19T18:36:34Z_) :gear: [JKube E2E Tests (2524887194)](https://github.com/jkubeio/ci/actions/runs/2524887194) - :heavy_check_mark: [Bootstrap CI test run (#1416)](https://github.com/jkubeio/ci/runs/6956885853?check_suite_focus=true) - :heavy_check_mark: [K8S v1.12.0 dockerfile...

I recall I fixed the `jkube-kit-common` module a while ago to work under windows. I just run the tests in the master branch, and they are still passing (on my...

> Maybe new changes broke them again? I don't know what to tell you. If I changed something there is because I needed to. I didn't just change things because...

Sounds good. This could be an optional enricher. I guess, that this requires java types to map Drone's custom resources. With the upcoming release of [Fabric8 Kubernetes Client 6.0](https://github.com/fabric8io/kubernetes-client) we'll...

:sweat_smile: Well, I guess I haven't checked the Drone project that much. Yes, this sounds good. I understand that the pipeline would generate a container image and maybe push it...

A possible solution is to check if the Resource already contains a defined matching label. - If the label exists we won't overwrite. - ??? provide a config option to...

### Eclipse JKube [CI Report](https://github.com/jkubeio/ci) Started new GH workflow run for https://github.com/eclipse/jkube/pull/1689 (_2022-08-03T11:14:29Z_) :gear: [JKube E2E Tests (2788809583)](https://github.com/jkubeio/ci/actions/runs/2788809583) - :heavy_check_mark: [Bootstrap CI test run (#1689)](https://github.com/jkubeio/ci/runs/7650178518?check_suite_focus=true) - :heavy_check_mark: [K8S v1.12.0 dockerfile...

I'd vote for our own extension. It won't be hard to implement and won't require additional dependencies. Something as simple as an annotation to set a system property and an...

~~Does your configuration change the image user, it should be 1000:1000?~~ OK, our generator defines the user as jboss:jboss:jboss, this must be something new for the current OpenShift version.

Are you sure you're running an S2i build and not an OpenShift Docker build? This part looks suspicious: `Generating dockerfile with builder image jboss/wildfly:25.0.0.Final`