Manu Garg

Results 85 comments of Manu Garg

@kushal288 Since the cache implementation is different for each surfacer, I think we'll need to implement this in each surfacer individually. I'll give it more thought, but one quick way...

I think we can standardize internal metrics with the following labels: `subsystem` and `subsystem_id`. For example, for stackdriver surfacer: `subsystem=surfacer, subsystem_id=stackdriver`

@kushal288 So the way it works is slightly more complicated than that. We do build an EventMetrics object and pass it on surfacers through a channel. In this case, instead...

Ah, I see. I guess there are a couple of ways to tackle this. I am not yet sure which one makes the most sense: (In no particular order) *...

Hello @jumpojoy, We didn't feel the need for surfacer extensions because extensions are truly useful when you want to have multiple types of them in a single process. For example,...

@sfc-gh-raram Cloudprober doesn't manage any cryptographic keys. Also, it doesn't have any persistent storage of data (or sensitive data). I am not sure how FIPS apply in such a case....

Note about this change: It will increase convenience but it will make cloudprober run dependent on external configs. For the most part it's okay -- it will only make debugging...

Thanks for the PR, @vtsingaras! Can you please summarize your changes.

Couple of big items before I do more in depth review: * Can you please generate the protobuf code again with protoc version 21.5. Following script should do this automatically...