Manu Garg

Results 85 comments of Manu Garg

> Sorry for leaving it without a comment. I didn't merge this because new driver doubles the size of the binary. I'll take another look at it. Binary size increase...

Please feel free to reopen if it's still an issue.

Thanks a lot @orbea for this PR. We don't need this anymore though -- #142 fixes both setup.py and runtests.py.

> @manugarg When you have a chance can you please review this PR and #137? Sorry for the late merge here. We don't need #137 any more.

I am considering abandoning the CUE support effort. To be honest, protobuf based configs have been working pretty well for us. The more I look at the other formats, more...

@hgsat123 Currently, there is no such way. The idea was whichever system is programming Cloudprober, will also take care of restarted processes and programming them again. Saving the current config...

I'm trying something here: https://github.com/cloudprober/cloudprober/pull/671/files If you provide a flag: --config_save_path, Cloudprober will automatically save config at that path after every change. You can also save config at an arbitrary...

Sorry for taking so long to merge #671. From my commit message: ``` If you start cloudprober with flag --probes_config_save_path, it will automatically save new probes config to the provided...

Thanks @hgsat123! I am marking this resolved for now. You can either reopen another issue for further work on this.

I think this is kind of interesting. We could add another condition type, say "spike" that would keep average of latencies over time and fire an alert if latency is...