Manu Garg

@mfboulos That's excellent. Logic for this should look very similar to how we do it for external probes: https://github.com/google/cloudprober/blob/master/probes/external/payload_metrics.go In fact, we should try to refactor the config and code...

I think external and payload parsing logic are sufficiently decoupled now. External probe initializes a payload parser at the time initialization: https://github.com/google/cloudprober/blob/eaaf78581bf97c71087e415da6e3a504267fb088/probes/external/external.go#L156 It updates payload metrics per target using this...

payloadParser.PayloadMetrics expects payload to just be a text that looks like this: For external probe it's produced by either running an external command: https://github.com/google/cloudprober/blob/5d8563a26e5c80fd65dd426c9901fb3b99708e76/probes/external/external.go#L522, or by sending a probe request...

There is a script in tools directory to generate protobuf code, did you give that a try?

Sorry for the insufficient (not so user-friendly) documentation. Probe config options can be derived from the protobuf fields. For example here is the config protobuf for the HTTP probe type:...

This is done through #194. See https://github.com/cloudprober/cloudprober/blob/master/validators/json/json_test.go for some examples.

MTR probe will not be straightforward, but one interesting way to get MTR on "ping" failure is to use the new alerting feature with command notifier. This was shared by...

This is how the provided docker image runs: --- ``` 14:13:04 @frodo ~$ docker run ghcr.io/manugarg/pactester:main pactester.c: You didn't specify the PAC file Usage: /app/pactester [-h host] [-c client_ip] [-e]...

This is implemented now. Please see #699 for more details.

Sorry for leaving it without a comment. I didn't merge this because new driver doubles the size of the binary. I'll take another look at it.