Manuel

Results 161 comments of Manuel

Are you aware of any "full typescript feature list" so that we can see which features we are still missing? I'm currently trying to work things out with the typescript...

As for the types based on `@typescript-eslint/types`: They are better than having nothing, but they have differences here and there that make things pretty annoying. I have opend an [issue](https://github.com/TyrealHu/acorn-typescript/issues/60)...

Good catch, that's actually on my "to experiment" list. Didn't had the time to investigate or see which AST spec `oxc-parser` is using.

I gave `oxc-parser` a go, but it does not seem to be there yet. As described above, the parser was never the problem, but the types that are generated from...

Undrafted, as this is completed functionality wise. The only remaining potential issue is in this review comment: https://github.com/Rich-Harris/esrap/pull/13#discussion_r1729148522 To sumarize a lot of the previous comments: * I could not...

Just noticed there are a few more things to do.

Hey, thanks for the suggestion. You are doing a totally valid assumption here, and I was kinda surprised to find out we had one integration but not the other. We...

Not at this point sadly. But since the adder definition is not ging to change (much), your changes should be pretty straigt forward to apply after our changes. We will...

> Also, just to clarify if I understood the "dangerous" part regarding adding first-class support for `typescript-acorn` nodes. Yeah, that also irritates me. I don't see anything that would be...

There is actually a test for that https://github.com/sveltejs/esrap/blob/d2cf14a01185ce6a1a072e10fbe1b026b6db201c/test/samples/comment-mixed-trailing/input.js#L1-L6 which produces https://github.com/sveltejs/esrap/blob/d2cf14a01185ce6a1a072e10fbe1b026b6db201c/test/samples/comment-mixed-trailing/expected.js#L1-L4 which i would personally consider as failing test instead of a passing one. Therefore i don't know if this...