Jonghyeon Ko

Results 124 comments of Jonghyeon Ko

ref https://github.com/codesandbox/sandpack

@minsoo-web Could I assign you for v2 docs soon? @sonsurim We need someone have no experience for this library to see how difficulty to onboard with this. Could you be...

> @manudeli I was just wondering, Could I see it when it's done? @sonsurim I guess that v2 will be release until at least in March, After then We need...

### reference https://github.com/TanStack/query/blob/main/.codesandbox/ci.json We can check examples in Pull Request too.

@kyujonglee 님 재엽님의 댓글에 나오는 react-query를 한 번 wrappinng한 hook이 이번에 오픈소스로 공개한 @toss/react-query의 [useSuspenedQuery](https://slash.page/libraries/react/react-query/src/hooks/useSuspendedQuery.i18n)와 비슷한 형태일 거 같아서 참고하면 좋을 거 같아요 참고로 이 훅은 react-query v3를 wrapping하고 있어요...

> I dont think we need `isSuccess`? Because if `x.error` has value or `x.isValidating`/`x.isLoading` is `true`. Then we can assume `isSuccess` is false right? Then don't we need to provide...

> @sanding0 do you know why wasnt this merged? it would be great!! Or is there a workaround? @tobbbe I think so too. Isn't this change better than now? Why...

@shuding @huozhi Then, Do we need to use useSWR like below to type narrowing? ```tsx const SWRComp = () => { const swrQuery = useSWR(...) if(swrQuery.data !== undefined){ return {swrQuery.data}...

@tobbbe @sanding0 I made new issue https://github.com/vercel/swr/issues/2482 relative with this Pull Request.

@sanding0 If you want, Could you link this issue to close it after this PR merging? https://github.com/vercel/swr/issues/2482 You can edit description (adding `fix https://github.com/vercel/swr/issues/2482`) of Pull Request or link it...