JsonSubTypes icon indicating copy to clipboard operation
JsonSubTypes copied to clipboard

New Major to depend on newer JSON

Open viceice opened this issue 4 years ago • 3 comments

Is your feature request related to a problem? Please describe. Currently this lin depends on Json v10 and our Project depends on Json v12. The problem is we need assembly signing and can't use binding redirects. Our assemblies need to be deployed to the windows GAC.

Describe the solution you'd like Release new major version which depends on Json v12 ( and v13 in a future release)

Describe alternatives you've considered Fork this project or hook into assembly resoving / loading

Additional context See Problem

*** Source/destination types

// not relevant

*** Source/destination JSON

{"message":"not relevant"}

viceice avatar Apr 01 '21 05:04 viceice

It conflicts with:

  • Newtonsoft.Json dependency version should be lowest supported, not latest available #101
  • Lower Newtonsoft.Json Support to 9.0.1 #41

manuc66 avatar Apr 05 '21 12:04 manuc66

I know, please do a major version bump when you change the JSON dep major version again, so the update doesn't silently pass through.

We use renovate to manage dependencies with partial automerge and automatic tests can't capture those binding issues 😕

viceice avatar Apr 08 '21 06:04 viceice

Will be the case once this will be released : https://github.com/manuc66/JsonSubTypes/pull/137

manuc66 avatar Sep 29 '21 22:09 manuc66