username-availability-checker icon indicating copy to clipboard operation
username-availability-checker copied to clipboard

Move requests_toolbelt to requirements.txt

Open manu-chroma opened this issue 5 years ago • 3 comments

Since it is not a test requirement and is actually used in the username_api source:

https://github.com/manu-chroma/username-availability-checker/blob/master/username_api.py#L8

manu-chroma avatar Oct 31 '18 21:10 manu-chroma

@manu-chroma, the reason i did like that is because the result of it is actually used in test, not the server. you can know that from travis file.

seeeturtle avatar Oct 31 '18 23:10 seeeturtle

but you cannot run the server without installing test requirements. That's why it should be moved into main requirements

manu-chroma avatar Nov 01 '18 04:11 manu-chroma

Then I think it should be only used when testing, not putting in requirements.txt

seeeturtle avatar Nov 01 '18 07:11 seeeturtle