phantomic
phantomic copied to clipboard
mantoni
Tests failing on clean master
➜ phantomic git:(master) make
test #13 "node_modules/.bin/browserify --debug test/sourcemaps-console.js | node bin/cmd.js" failed:
expected " at test/sourcemaps-console.js:3"
got " s node_modules/browser-pack/_prelude.js:1"
test #21 "node bin/cmd.js < test/timezone.js" failed:
expected "-60"
got "-120"
test #22 "node bin/cmd.js < test/timezone.js" failed:
expected "300"
got "240"
3 of 22 tests failed in 18.652s.
Makefile:4: recipe for target 'default' failed
make: *** [default] Error 1
Just wanted to see if it wasn't just me.
- Ubuntu 16.04
- node v6.4
Ah, that looks like the tests only pass in my timezone haha ✨ Thanks for reporting!
I'm working on adding a feature. I'll check the post for plane tickets. :wink:
But seriously, that explains the last 2 failures, but not test 13.
Ok, so I just checked on my machine and I see the exact same failures. The last time I worked on this project, I ran the tests on PhantomJS 1.9 and now I'm running 2.0. It might have to do with that, but it clearly has nothing to do with timezones ... Which version are you using?
➜ phantomic git:(master) ✗ npm ls --depth 0
[email protected] /home/phred/src/git/phantomic
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] extraneous
└── [email protected]
➜ phantomic git:(master) ✗ npm --version
3.10.3
➜ phantomic git:(master) ✗ node --version
v6.4.0
➜ phantomic git:(master) ✗ nvm --version
0.31.2
I have pushed a fix for the timezone tests. It was DST related. The sourcemaps related test still fails though.