source-integration icon indicating copy to clipboard operation
source-integration copied to clipboard

Pre-commit checking via Source Integration

Open bright-tools opened this issue 9 years ago • 2 comments

Write up of the changes

Essentially it's implementing similar functionality to that which was previously provided by ScmBug, using the information in Mantis to validate commits via a pre-commit hook.

If you're happy with this I'll plan to add support for other version control systems. Please let me know if any changes are required before you'll accept this.

Thanks,

John

bright-tools avatar Jan 28 '15 18:01 bright-tools

Thanks for your contribution. It looks like an interesting feature, but I unfortunately really don't have the time to review your code at the moment, so it's likely that your pull request will remain open for some time. Please bear with me.

dregad avatar Jan 30 '15 08:01 dregad

No problem, I know how it is :-)

Glad that you'd consider accepting the pull request - we previously used ScmBug for this kind of checking, but unfortunately it doesn't seem to be maintained any more (and throws dire warnings when using it with more modern versions of the software it interfaces with than were available at the time of the last release). On more than one occasion it has helped to prevent accidents, such as committing against the wrong (or a non-existent) ticket due to a transpositional error when typing the ticket number into the comment!

Let me know if there's anything I can do to help out - more than happy to make changes, etc.

bright-tools avatar Jan 30 '15 09:01 bright-tools