mantine icon indicating copy to clipboard operation
mantine copied to clipboard

Leave animation should be the progress getting complete instead of resetting to the start

Open italodeandra opened this issue 3 years ago • 2 comments

What package has an issue

@mantine/nprogress

Describe the bug

When the navigation progress completes, the animation of the progress should be to fill the entire width instead of going to 0.

Reference: https://ricostacruz.com/nprogress/

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

Yes

italodeandra avatar Sep 05 '22 13:09 italodeandra

Feel free to send a PR with this feature

rtivital avatar Sep 05 '22 13:09 rtivital

Help is still wanted on this, if someone wants to submit a PR feel free to ping me here.

rtivital avatar Sep 14 '22 13:09 rtivital

Help is still wanted on this, if someone wants to submit a PR feel free to ping me here.

i tried to fix this issue. The idea is instead of calling resetNavigationProgress when the page load is done which will set the progress to 0 and reset the progress, now can use finishNavigationProgress to set the progress to 100, so progress will fill the entire width and then set the autoReset to true to automatically reset the progress bar.

zulianrizki avatar Sep 24 '22 10:09 zulianrizki

Fixed in 5.5.0

rtivital avatar Oct 02 '22 10:10 rtivital