mantine icon indicating copy to clipboard operation
mantine copied to clipboard

Spotlight should close when running closeSpotlight in onTrigger

Open Meierschlumpf opened this issue 3 years ago • 3 comments

What package has an issue

@mantine/spotlight

Describe the bug

When using spotlight-provider with closeOnActionTrigger set to false and defining actions with onTrigger the closeSpotlight function is not working.

What version of @mantine/hooks page do you have in package.json?

5.0.3

If possible, please include a link to a codesandbox with the reproduced problem

https://codesandbox.io/s/mantine-spotlight-close-issue-nx3hq4

Do you know how to fix the issue

No

Are you willing to participate in fixing this issue and create a pull request with the fix

No

Possible fix

No response

Meierschlumpf avatar Aug 07 '22 20:08 Meierschlumpf

Thanks for reporting, I'll add an option to override closeOnActionTrigger on action level in one of the next releases.

rtivital avatar Aug 07 '22 21:08 rtivital

I would create a pr if it's fine :). It will be finished until tomorrow.

Meierschlumpf avatar Aug 08 '22 05:08 Meierschlumpf

Sure

rtivital avatar Aug 08 '22 07:08 rtivital

Fixed in 5.1.1

rtivital avatar Aug 11 '22 15:08 rtivital