mantine icon indicating copy to clipboard operation
mantine copied to clipboard

AppShell Navbar footer hidden for mobile users with address bar on top

Open sunneydev opened this issue 2 years ago • 4 comments

What package has an issue

@mantine/core

Describe the bug

As mobile browsers implement vh units as the height of the screen the bottom part of the Navbar is not visible unless you manually scroll.

Footer not visible

photo_2022-04-03_08-59-45

Footer visible after scrolling

photo_2022-04-03_08-59-45--2-

unknown

In which browser did the problem occur

Any mobile browser with address bar on top

If possible, please include a link to a codesandbox with the reproduced problem

https://codesandbox.io/s/beautiful-water-4ipk7d

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

No response

Possible fix

credits to @mattrunyon

Adding sx={{ bottom: 0, height: "auto" }} to Navbar

sunneydev avatar Apr 03 '22 05:04 sunneydev

Thanks for reporting and investigation

rtivital avatar Apr 03 '22 07:04 rtivital

Also getting this error, let me know if more information is needed.

TobiasHansen avatar May 04 '22 20:05 TobiasHansen

Thanks for the temporary solution.

rayhk6 avatar Jul 15 '22 06:07 rayhk6

I have figured out if you add a bottom padding of paddingBottom: props.theme.spacing.xl it goes away GitHub link

IAFahim avatar Jul 25 '22 16:07 IAFahim

Fixed in 5.1.4, Navbar now has bottom: 0 css property, we cannot set height to auto though as there are header and footer height dependencies in css variables. Height can be set with corresponding prop: <Navbar height="auto" />

rtivital avatar Aug 12 '22 07:08 rtivital