mantid
mantid copied to clipboard
Pin orsopy version to 1.2.0
Description of work
Pins the orsopy dependency to version 1.2.0.
Purpose of work
We use the orsopy library to produce the ISIS Reflectometry reduced output file (see algorithm SaveISISReflectometryORSO
). I'm keen that we have tests that are quite sensitive to changes to the file layout and content (there are some already and I'm planning to add more). If the orsopy dependency updates automatically and the new version changes something about the layout or content then this would cause tests to fail, blocking everyone's PRs. Instead we have agreed that it's better to pin orsopy and instead the LSS Team will check for updates once per release and manually update it if a new version is available. This will also allow us to monitor and modify unit and system tests over time if we find they are too sensitive, but without impacting others.
There is no associated issue.
To test:
All tests should pass.
This does not require release notes because it is not a user-facing change.
Reviewer
Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
- Is the code of an acceptable quality?
- Does the code conform to the coding standards?
- Are the unit tests small and test the class in isolation?
- If there is GUI work does it follow the GUI standards?
- If there are changes in the release notes then do they describe the changes appropriately?
- Do the release notes conform to the release notes guide?
Functional Tests
- Do changes function as described? Add comments below that describe the tests performed?
- Do the changes handle unexpected situations, e.g. bad input?
- Has the relevant (user and developer) documentation been added/updated?
Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers
will take care of it.
Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.