mantid
mantid copied to clipboard
Improve wallclock filtering in LoadEventNexus
As part of EWM3412, the PulseIndexer
class needs improvements to allow for only processing pulses that are requested. This is a start in that direction and provides a mechanism for skipping the pulses at the beginning and end of the arrays in the file.
Question for the reviewer: should this implement special cases for using all of the pulses?
Refs #36594 and EWM3412
To test:
This is mostly an internal refactor. As a result, this is probably best tested by looking through the changes and additional tests.
This does not require release notes because it is an internal improvement that will be covered by release notes in a future story.
Reviewer
Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
- Is the code of an acceptable quality?
- Does the code conform to the coding standards?
- Are the unit tests small and test the class in isolation?
- If there is GUI work does it follow the GUI standards?
- If there are changes in the release notes then do they describe the changes appropriately?
- Do the release notes conform to the release notes guide?
Functional Tests
- Do changes function as described? Add comments below that describe the tests performed?
- Do the changes handle unexpected situations, e.g. bad input?
- Has the relevant (user and developer) documentation been added/updated?
Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers
will take care of it.
Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.