mantid icon indicating copy to clipboard operation
mantid copied to clipboard

Tweak version in conda

Open peterfpeterson opened this issue 2 years ago • 0 comments

This allows for the tweak version to be set via conda as well as coded into cmake directly. There is also some minor cleanup as the tweak version is now more universally applied.

To test:

Run cmake with different values of PKG_VERSION injected and CONDA_BUILD turned on. The examples in the comment of VersionNumber.cmake are a good set as they cover all the options. Example:

PKG_VERSION="6.4.20220915.1529" cmake -D CONDA_BUILD=True .

will print Version: 6.4.20220915.1529 in the cmake configuration logs and look at the values in the templated file Framework/Kernel/src/MantidVersion.cpp that they are accurate.

There is no associated issue.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Are the release notes saved in a separate file, using Issue or PR number for file name and in the correct location?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

peterfpeterson avatar Sep 16 '22 18:09 peterfpeterson