mantid icon indicating copy to clipboard operation
mantid copied to clipboard

EPIC: Polarised reflectivity reduction in NR GUI

Open gemmaguest opened this issue 3 years ago • 1 comments

Some changes are required to be able to run Polref experiments in the ISIS Reflectometry GUI. This would be particularly useful for soft matter users, who are more familiar with the GUI than with the scripts that Polref currently uses. Some of the additional steps used/required for Polref would also be useful for the other instruments, so there is benefit in consolidating the workflows.

A brief summary of the main steps required, in order of priority, is:

Perform polarisation correction:

  • [x] Allow to specify polarisation correction workspace file in the GUI similar to a flood workspace instead of using the parameters file - the remaining work needed for this is detailed in #34812 .
  • [ ] #35525
  • [ ] #35682 - We would need to be well-documented to make it transparent to users exactly what the algorithm is doing, as users have commented that they currently find this difficult to establish, particularly if trying to read the code.
  • [ ] Need to be able to customise the order of the flippers to match the workspace (Polref does not use the order currently assumed) - #35067
  • [x] #34940

Additional steps required for Polref reduction:

  • [ ] #34934 - change theta-in based on the calibration file. For summing in Q, need to do full pixel adjustment from the calibration. Review requirements against the algorithm we have already added for INTER, as POLREF should be similar but they measure positions in angles rather than mm.
  • [ ] Fit the specular peak using Bumps or similar.

General improvements:

  • [ ] There are currently some bugs in producing the workspace history from the workflow algorithms used by the GUI, in particular when the input is a workspace group. We should fix this so we can fully reproduce the reduction, and it would also aid with transparency.
  • [x] #34843 - Adding output stitch options to the parameters file.
  • [x] Improving stitched group child workspace names. Also polarization workspace names have been mentioned.

New features:

  • [ ] Get the error on the fitted peak from the fitter. Bayesian analysis preferred, but would want to be able to turn this off because it's very slow.
  • [ ] Add diagnostic tools to the GUI to be able to view the flood workspace, background subtraction workspace etc. Using these tools, it should be possible to auto-populate ROIs from fitting performed using the diagnostic tools to speed up the process of entering all the required settings by hand. It should then be possible to manually change these settings, while preventing any further diagnostic fitting from overwriting them.
  • [ ] Polref run experiments where each sample is very different and requires all the cropping lambda/Q ranges etc. to be adjusted for every run. This is currently quite cumbersome in the GUI because it requires clicking on boxes in different tabs to edit each start and end value. It would be good to think about how we might streamline this.

gemmaguest avatar Aug 18 '22 12:08 gemmaguest

We have now written an epic to cover this work. The following issues are included in the epic:

  • #36685
  • #36396
  • #37162
  • #35067
  • #36981
  • #37617
  • #35682
  • #35525
  • #36978
  • #36979
  • #36980
  • #36983
  • #36984
  • #36985
  • #37065

rbauststfc avatar Mar 06 '24 10:03 rbauststfc

This issue has been automatically marked as stale because it has not had activity in a year. It will be closed in 7 days if no further activity occurs. Allowing issues to close as stale helps us filter out issues which can wait for future development time. All issues closed by stale bot act like normal issues; they can be searched for, commented on or reopened at any point. If you'd like a closed stale issue to be considered, feel free to either re-open the issue directly or contact a developer. To extend the lifetime of an issue please comment below, it helps us see that this is still affecting you and you want it fixed in the near-future. Extending the lifetime of an issue may cause the development team to prioritise it over other issues, which may be closed as stale instead.

github-actions[bot] avatar Jun 28 '25 00:06 github-actions[bot]

This issue has been closed automatically. If this still affects you please re-open this issue with a comment or contact us so we can look into resolving it.

github-actions[bot] avatar Jul 06 '25 00:07 github-actions[bot]