manticoresearch icon indicating copy to clipboard operation
manticoresearch copied to clipboard

Add support for Ubuntu Noble 24.04

Open sanikolaev opened this issue 1 year ago • 17 comments

Proposal:

Ubuntu Noble 24.04 is out. We need to add support for it:

  • [ ] add new sysroots
  • [x] consider rebuilding dockers:
    • [x] testing docker
    • [x] building docker
    • [x] Manticore's official docker & test-kit
  • [ ] add new dirs on repo.manticoresearch.com
  • [ ] update repomanager's scripts if required
  • [ ] update CI:
    • [ ] github
    • [ ] gitlab
  • [x] Update CLT tests that rely on the supported OS list
  • [ ] Add the new Ubuntu version in all the projects:
    • Executor
    • Backup
    • Buddy
    • MCL

UPDATE

We've decided to just map it to Ubuntu Jammy, so the above is not actual. See https://github.com/manticoresoftware/manticoresearch/issues/2091#issuecomment-2097454522

Checklist:

To be completed by the assignee. Check off tasks that have been completed or are not applicable.

  • [x] Task estimated
  • [x] Specification created, reviewed and approved
  • [x] Implementation completed
  • [x] Tests developed
  • [x] Documentation updated
  • [x] Documentation proofread
  • [x] Changelog updated
  • [x] OpenAPI YAML updated and issue created to rebuild clients

sanikolaev avatar Apr 26 '24 09:04 sanikolaev

@klirichek the next step is these 2 sub-tasks:

  • add new sysroots
  • update gitlab CI to test the above

sanikolaev avatar Apr 29 '24 05:04 sanikolaev

@djklim87 at first glance it looks like it would be enough to just map Noble to Jammy in manticore-dev-repo.noarch.deb. So here's the new plan:

  • [x] Map Noble to Jammy in manticore-dev-repo.noarch.deb
  • [x] Test it using our installation/upgrade tests (https://github.com/manticoresoftware/manticoresearch/actions/runs/8975004046/job/24648634626). Add Ubuntu Noble to the list.
  • [x] Test manually than indexation from MySQL and Postgres works when Manticore is installed in Ubuntu Noble
  • [x] If all is ok - announce Ubuntu Noble support in the changelog.

sanikolaev avatar May 07 '24 05:05 sanikolaev

All fine, but you should install libmysqlclient21 and libpq5 for indexer

KlimTodrik avatar May 08 '24 15:05 KlimTodrik

@PavelShilin89 reassigning to you to make sure the new OS is covered with tests.

Can't find this test:

➜  workflows git:(master) grep -i jammy -r *|grep clt
clt_nightly.yml:          - name: Jammy release installation
clt_nightly.yml:            image: ubuntu:jammy
clt_nightly.yml:          - name: Jammy upgrade to dev
clt_nightly.yml:            image: ubuntu:jammy

for Noble:

/Users/sn/manticore_github/.github/workflows
➜  workflows git:(master) grep -i noble -r *
➜  workflows git:(master)

sanikolaev avatar May 09 '24 05:05 sanikolaev

I also see this in Noble running in docker on Mac M1:

MySQL [(none)]> create table t(f text);
ERROR 1064 (42000): error adding table 't': can't create directory: /var/lib/manticore/t

sanikolaev avatar May 09 '24 05:05 sanikolaev

I also see this in Noble running in docker on Mac M1:

Nevermind. Seems to be not a Manticore's problem:

root@d73aa4f25bbb:/# sudo -u manticore mkdir /var/lib/manticore/t
mkdir: cannot create directory '/var/lib/manticore/t': No space left on device

sanikolaev avatar May 09 '24 05:05 sanikolaev

Done in https://github.com/manticoresoftware/manticoresearch/pull/2147

PavelShilin89 avatar May 13 '24 13:05 PavelShilin89

If all is ok - announce Ubuntu Noble support in the changelog

Done.

Closing the issue as done.

sanikolaev avatar May 16 '24 03:05 sanikolaev

Closing the issue as done.

Still missing here:

  • https://manual.manticoresearch.com/Installation/Debian_and_Ubuntu#Installing-Manticore-in-Debian-or-Ubuntu
  • https://repo.manticoresearch.com/repository/

marclaporte avatar Sep 07 '24 15:09 marclaporte

Thanks @marclaporte

manual.manticoresearch.com/Installation/Debian_and_Ubuntu#Installing-Manticore-in-Debian-or-Ubuntu

Fixed here https://github.com/manticoresoftware/manticoresearch/commit/c16cb0aa7854647f7c680956058a4e7d723e36c2

repo.manticoresearch.com/repository

Doesn't require fixing since the Noble packages are identical to Jammy's. The official installation instructions take that into account and use the Jammy packages when installing on Noble.

sanikolaev avatar Sep 10 '24 11:09 sanikolaev