unix socket, php8 match keyword

[mitsh]

UnixSocket support added. Class "Match" renamed to "QueryMatch" because of PHP8 'match' reserved keyword.

[adriannuta]

Hi, as I said here Match is planned to be renamed to MatchQuery, not QueryMatch.. Also please validate the code against phpcs --standard=PSR2. Thanks

[mitsh]

Hi, okay I will do that and let you know.

[mitsh]

Hi @adriannuta, I used Swoole as a client in this transport. Is it good for the project?

[adriannuta]

@mitsh any advantage in this context to use the Swoole Client vs something more native like stream? One would have to install the Swoole extension.

[mitsh]

@adriannuta yeah I got it. I will change the Swoole Client to a native one like fsockopen.

[adriannuta]

fsockopen (or stream_socket_client) sounds better. Also have you tried with curl using CURLOPT_UNIX_SOCKET_PATH ? Haven't tested, but curl should be able to open sockets since php 7.0 (not sure which would be better, curl vs fsockopen/stream_socket_client)

[mitsh]

yes, I think so it is better(fsockopen). I've also tried as you mentioned with curl but it is not a stable option. php-curl extension should compile with the latest curl library.

[adriannuta]

Please note that I committed today changes for compatibility with PHP 8.0, including the rename of the Match class.

[Nick-S-2018]

The unixsocket support task is still not finished as discussed above.

[mitsh]

after a very long time. hello guys, if you haven't added unixsocket support yet. i can do the fixes and rerequest PR for it.

[sanikolaev]

i can do the fixes and rerequest PR for it.

Please do