Chris Manson

Results 323 comments of Chris Manson

Just to update on this: our current thinking is that we shouldn't ignore all addons, but instead just `@embroider/macros` you can update your viteconfig to express this but we ultimately...

@johanrd I think we're past the point that things "often and unreliably" don't end up in vite deps with the current main/unstable version of vite support. I replied to that...

I just figured out the problem that was causing this for us. Essentially the HTML proxy module code doesn't work with Windows truncated long paths. You can see in this...

I would expand on what @ef4 summarised from the RFC review. One of the biggest blockers for development is that we are testing ember-cli in `npm`, `yarn`, and `pnpm` and...

We decided at the learning team meeting yesterday that we are merging this PR and any fixes can be done on a fix-forward basis. Thank you everyone for your work...

This is blocked on https://github.com/embroider-build/embroider/pull/2016

for the record this change would need to happen on ember-styleguide: https://github.com/ember-learn/ember-styleguide/blob/master/addon/constants/es-footer.js#L3-L8

well yes we could update the content of the twitter logo class but I would probably rename `twitter-logo` to `x-logo` and you can update the content 👍 You can also...

it's very hard to see the error since it's rendered all in one big line, are you able to fix the output? or are you able to produce a reproduction...