mans0n

I don't feel duplicating driver files is a good practice... The git log of mediatek target shows codes were moved to generic in such cases. bcf91fe8849b cc49abc06bca

> Has MT7915 EEPROM issue. Just curious, what was the problem and how did you fix it?

Just FYI, "[Mercusys](https://www.mercusys.com/)" is a new brand name for global market, and the domestic vendor name is still "[Mercury](https://www.mercurycom.com.cn/)". We have two Mercury devices in this repo, and [MW4530R](https://openwrt.org/toh/mercury/mw4530r_v1) is...

> ramips: add support for Mercusys MR70X > Add support for Mercusys MR70X. Please insert a blank line right after the commit title.

I can't say much for the flash patch. If you send it to upstream and it is accepted, then I think it's good to go. But the device patch seems...

> To me it looks as if there devices on both busses.. but it's quite possible I'm doing a horrible mistake here. > Could you have a look? Here's what...

Hi, please stick to the original PR next time. https://openwrt.org/docs/guide-developer/frequent-pr-mistakes#do_not_multi-post_or_re-post_prs Your patch has too many things in a single commit, I suggest to split it out. (e.g. one commit for...

> Do you think, I should create separate PRs for each of the devices? Or just separate commits? Should the commit message then look like the big one or should...

> Have discovered an issue in testing with the meraki-hdr function in that it assumes the crc32 utility is available on the host where it may not be by default...

As you are the first-time contributor and you said you copied RT-AC57U dts file, I request you to check these (again): 1. Does "LED-Power" regulator exist on your device? (What...