halo
halo copied to clipboard
Added optional stripping to allow whitespacing
Description of new feature, or changes
Added an optional strip parameter to the constructor of the Halo object to address the issue #113 . By making this optional parameter False at the constructor it will no longer strip text, allowing whitespace when start function is being called with a text parameter.
Checklist
- [x] Your branch is up-to-date with the base branch
- [ ] You've included at least one test if this is a new feature
- [x] All tests are passing
Related Issues and Discussions
FIxes #113
Pull Request Test Coverage Report for Build 347
- 9 of 10 (90.0%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.4%) to 89.848%
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
---|---|---|---|
halo/halo.py | 9 | 10 | 90.0% |
<!-- | Total: | 9 | 10 |
Totals | |
---|---|
Change from base Build 346: | -0.4% |
Covered Lines: | 291 |
Relevant Lines: | 316 |
💛 - Coveralls
@UltraWelfare Apologies for late reply. This will need test cases before getting reviewed! :)
Please let me know if you need any assistance.