SingleDivProject icon indicating copy to clipboard operation
SingleDivProject copied to clipboard

Re-use `css-flags`

Open pixelastic opened this issue 8 years ago • 2 comments

Awesome project,

Maybe you would be interested in css-flags (repo) where I did 170 flags with one div :)

image

I'd be happy to contribute, but copy-pasting the code form one repo to another won't be the most effective way to maintain it. Maybe just a link between projects, or a git submodule?

pixelastic avatar Jun 22 '16 10:06 pixelastic

@pixelastic Hey! This is so cool! :smile:

We should definitely have section linking to awesome Single Div repositories/sections. But we already have a section for flags. I see there are already overlapping flags. Please share your view on how to proceed. :blush:

manrajgrover avatar Jun 22 '16 11:06 manrajgrover

There are several ways to do the same flag, so it's always nice to see how others did it.

The best (for me), would be to have a link to css-flags in your readme (and I can do the same in mine), and people can create PR for missing flags in css-flags. That would mean removing all the nice other implementations you already have.

So maybe just a note saying that if people want to add a new flag, maybe check on css-flags if it wasn't already done? I don't have any strong opinion on the subject :)

pixelastic avatar Jun 22 '16 12:06 pixelastic