pregex icon indicating copy to clipboard operation
pregex copied to clipboard

Contributing to pregex

Open dylannalex opened this issue 2 years ago • 8 comments

This project is really cool. People (including myself) might be interested in contributing. Are you accepting Pull Requests and/or planning to add a Contributing guide?

dylannalex avatar Aug 04 '22 15:08 dylannalex

Hey there, and thank you for expressing your interest! I'm certainly planning on adding a CONTRIBUTING file for the project so people can report bugs, propose modifications/additions, open pull requests etc, but first, I would like to finish with pregex's core modules as there are currently lots of changes happening constantly in the background, therefore, it would be pointless for people to propose an improvement regarding some piece of code that might as well have already been removed from the next version. Once I finish with some last things (and I'm guessing this won't take very long), everybody is welcome to contribute!

manoss96 avatar Aug 04 '22 18:08 manoss96

Do you have a timeline on when you expect to be finished? This looks like a fantastic way to preserve the expressive power of regex while still having them be readable by mere mortals! :)

AlexisGoodfellow avatar Aug 05 '22 19:08 AlexisGoodfellow

Do you have a timeline on when you expect to be finished? This looks like a fantastic way to preserve the expressive power of regex while still having them be readable by mere mortals! :)

I'm gonna try having pregex v1.4.0 out by Monday. I'm hoping that there won't be any big changes in pregex's internals after this release so people can test it for bugs as much as possible as well as maybe propose a new addition!

manoss96 avatar Aug 06 '22 04:08 manoss96

I'd love to help out on this eventually too - this is a great project.

patpragman avatar Aug 11 '22 04:08 patpragman

is there going to be a way to recognize \w eventually?

patpragman avatar Aug 11 '22 04:08 patpragman

is there going to be a way to recognize \w eventually?

\w is already recognized! It corresponds to "pregex.classes.AnyWordChar()" by setting the parameter "is_global" to "True". Only thing is, you are not allowed to subtract another class from an instance of AnyWordChar(is_global=True).

manoss96 avatar Aug 11 '22 05:08 manoss96

Damn, I was just skimming through the classes and I must have missed it - sorry for that. This is really great.

I'm kind of a newby at all of this, but spending some time learning re right now before I go back to school in the fall. Like I said, if I can, I'd love to help out. Time permitting this semester, I'd love to help with documentation - I was a technical writer in a former life.

patpragman avatar Aug 11 '22 05:08 patpragman

Damn, I was just skimming through the classes and I must have missed it - sorry for that. This is really great.

I'm kind of a newby at all of this, but spending some time learning re right now before I go back to school in the fall. Like I said, if I can, I'd love to help out. Time permitting this semester, I'd love to help with documentation - I was a technical writer in a former life.

Hahaha no worries! Well, the documentation page is built from files in docs/ as well as from the classes' own documentation within the source code itself. If you come across some typo, or you think that something can be rephrased in order to better convey its meaning, let me know!

manoss96 avatar Aug 11 '22 05:08 manoss96