gwt-api-generator icon indicating copy to clipboard operation
gwt-api-generator copied to clipboard

Allow using Webcomponents.js 1.x

Open wdkuc opened this issue 6 years ago • 3 comments

This change is Reviewable

wdkuc avatar Nov 28 '17 08:11 wdkuc

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


lib/com/vaadin/polymer/Polymer.java, line 51 at r1 (raw file):

     */
    @JsProperty(namespace = JsPackage.GLOBAL)
    public static native void setWebcomponentsJsLocation(String s);

Any reason for publishing this variable in window scope? I think just a static string in this class might be enough


Comments from Reviewable

manolo avatar Dec 11 '17 08:12 manolo

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.


lib/com/vaadin/polymer/Polymer.java, line 67 at r1 (raw file):

        }
        if(getWebcomponentsJsLocation() == null) {
            setWebcomponentsJsLocation("webcomponentsjs/webcomponents-lite.min.js");

shouldn't it be webcomponents-lite.js instead ?


Comments from Reviewable

manolo avatar Dec 11 '17 08:12 manolo

in my other PR i renamed the file, since the webcomponents-lite.min.js is not there anymore.

vegegoku avatar Dec 11 '17 08:12 vegegoku