nova-tiptap icon indicating copy to clipboard operation
nova-tiptap copied to clipboard

Allow customisation of image inline setting

Open kenneth-hendricks opened this issue 3 years ago • 5 comments

Hi,

It would be great if this library allowed users to set the inline setting for the images extension. This is required if you want to allow images to be made linkable. From what i can see there is no way to set this currently.

https://tiptap.dev/api/nodes/image

kenneth-hendricks avatar Mar 30 '22 23:03 kenneth-hendricks

Need this.

curder avatar May 09 '22 09:05 curder

Hey @manogi, I'm preparing a PR for this issue, but I encounters troubles to install local dependencies because of FontAwesomePro. Can I PR the updated sources? You'll only have to compile them. Thanks

shaffe-fr avatar Oct 11 '22 09:10 shaffe-fr

Yes, we can try this

bastihilger avatar Oct 11 '22 09:10 bastihilger

IMO images should always be embed as inline. Do you agree or would you prefer a new imageSettings.inline option? Thanks

shaffe-fr avatar Oct 11 '22 09:10 shaffe-fr

It will take me a bit longer to answer this - I am currently not actively using Nova (or TipTap) and will have to re-install my testing environment for it.

bastihilger avatar Oct 11 '22 09:10 bastihilger

Any updates on this ? I will open a PR if needed

alexgilbertDG avatar Feb 09 '23 21:02 alexgilbertDG

Hey, I changed the rich text editor I'm using for creditor 4. I'll share what I already have.

shaffe-fr avatar Feb 09 '23 22:02 shaffe-fr

Hey @alexgilbertDG, I have this https://github.com/shaffe-fr/nova-tiptap/tree/inline-image

shaffe-fr avatar Feb 20 '23 15:02 shaffe-fr

@manogi Any update about this issue, we would like to add <a href url for image and without that we can't do it....

alexgilbertDG avatar Oct 11 '23 20:10 alexgilbertDG