react-tweet icon indicating copy to clipboard operation
react-tweet copied to clipboard

Published 20 hours ago • verified publisher icon mannynotfound

Styled components

Open sudarshang opened this issue 6 years ago • 2 comments

This PR is to get feedback on the right way to migrate this project to styled-components. I have only migrated the Video component for now. @art1fa please let me know if this is how #25 should be handled.

sudarshang avatar Mar 22 '18 20:03 sudarshang

Yeah looks fine :) Just two comments:

  • It probably makes sense to organize the styles in another place than the actual component. This is one example, but of course there's more than one way...
  • Move the dependency in devDependencies and peerDependencies (see this)

zebra-ok avatar Mar 23 '18 12:03 zebra-ok

hey guys, thanks for the PR! Was out of town all weekend so havent gotten a chance to look at this but will provide some feedback soon.

mannynotfound avatar Mar 27 '18 14:03 mannynotfound