react-tweet icon indicating copy to clipboard operation
react-tweet copied to clipboard

Prettify all the code (ie run prettier)

Open sudarshang opened this issue 6 years ago • 2 comments

I followed this blogpost to run prettier on this repo.

This was the command I used to run prettier

git filter-branch -f --tree-filter '\
    prettier --single-quote   \
    --trailing-comma es5 \
    --print-width=100 --write "**/**.js" || \
    echo “Error formatting, possibly invalid JS“' -- --all

I pushed the branch with the rewritted git history to my repo

https://github.com/sudarshang/react-tweet/tree/prettify

Would you be interested in doing a force merge of that branch? I don't have any strong opinions about prettier options. If you want to use another set of options that would be totally fine with me. Since I started with prettier working without automated code formatting has become very difficult for me.

sudarshang avatar Mar 21 '18 20:03 sudarshang

hey @sudarshang im not seeing the changes on that branch? the latest commits are from myself

mannynotfound avatar Mar 21 '18 21:03 mannynotfound

The git filter-branch command re-writes history. So there are no new commits on that branch. All the commits that have already happened have been rewritten to have the prettier auto formatting. If you git clone that repo into a separate directory you can run diff to see how the files have been changed.

sudarshang avatar Mar 21 '18 22:03 sudarshang