node-klaw-sync icon indicating copy to clipboard operation
node-klaw-sync copied to clipboard

.asar files are treat like folders

Open rasq opened this issue 6 years ago • 5 comments

OS: Windows 10.

Unfortunetly klaw-sync treat .asar folders like foders and list's all files that are inside.

this is very problematic, because thouse files are not accesible, example: electron.asar\browser\api\app.js electron.asar\browser\api\auto-updater\auto-updater-native.js

rasq avatar Mar 07 '18 20:03 rasq

@rasq according to electron docs, node APIs treat asar archives as directories. What is the exact problem that you are facing?

manidlou avatar Mar 07 '18 22:03 manidlou

It will be good to have option to set archives as files for klaw. Why? Because sometimes someone will use a files/directories list from klaw and he/she will might to use it for some reason, maybe to create list for software that will check each file, on for archive tool, or maybe to create MSI package. On this cases files from archive are not accesible but they are listed, and error will occure. I'am having some simillar problem, im generating xml for WixToolset using electron and klaw. And .asar archive are problems, (i need only have file path to .asar, not path to asar and files inside).

rasq avatar Mar 08 '18 05:03 rasq

Hey, late response but now you can filter out directories when traversing. You can look at this test to see how you can do it.

Geelik avatar Sep 13 '18 20:09 Geelik

Im facing this exact problem right now. Treating .asar as directory is a killer when trying to create an MSI package using wix. Would be nice to have a clear example of how to treat them like files.

Current Code from electron-wix-msi (https://github.com/felixrieseberg/electron-wix-msi)

function getDirectoryStructure(root) { return new Promise((resolve, reject) => { if (!fs.existsSync(root)) { return reject(new Error(App directory ${root} does not exist)); } const files = []; const directories = []; klaw(root, { }) .on('data', (item) => { if (item.stats.isFile()) { files.push(item.path); } else if (item.stats.isDirectory() && item.path !== root) { directories.push(item.path); } }) .on('end', () => resolve({ files, directories })); }); }

markmorris avatar Oct 15 '18 15:10 markmorris

@markmorris your code uses klaw and not klaw-sync. I'd recommend to open an issue there!

manidlou avatar Oct 17 '18 03:10 manidlou