Mani Maghsoudlou

Yeah we already get the src and dest stats before we check the filter, so yeah we could pass them to the filter function.

@RyanZim I agree with you in terms of being aligned with node core. However, generally speaking, having `fs.cp()` in node core, creates an interesting situation for us! What I mean...

Yeah since Node has that option, we should add that too. I also agree with you that we should use `fs.rm` wherever is possible. > Naming stuff is hard :smile:...

@Offirmo can you please give us a reproducible test case?

This is not a bug, it is an expected behavior. For directories, `fs-extra` copies everything inside the directory (not the directory itself). It is also mentioned in our docs https://github.com/jprichardson/node-fs-extra/blob/master/docs/copy.md....

What should happen when a newline character exists in the path? error out?

@wrager yes delegating to the OS makes sense. @RyanZim you are right! there is inconsistency in error codes that OSes throw! Not only that, there is a big discussion on...

I am ok with `copyFileMode`.

I figured I could reopen this instead of creating a new issue :grin: So another thing that we need to think about here at `fs-extra` is the options for copy...

I am not completely sure but I feel like it is out of scope. For this, we probably need to have OS specific implementations. Also, I don't think we can...