hamilton icon indicating copy to clipboard operation
hamilton copied to clipboard

Add User Thumbnail Upload

Open Threpio opened this issue 2 years ago • 2 comments

Required for: https://github.com/hashicorp/terraform-provider-azuread/issues/1012

Do I need to add a different logo than the one that is used for Applications thumbnails? No I will be the application.

Threpio avatar Feb 23 '23 13:02 Threpio

@Threpio Could you take a look at the test failure?

manicminer avatar Feb 27 '23 20:02 manicminer

This error is bizarre - The documentation for this endpoint is duplicated between /user/{id}/thumbnailPhoto and /user/{id}/photo/$value - I will change it to use the second endpoint as that is more in line with the docs.

HOWEVER - In doing so:

https://github.com/manicminer/hamilton/blob/6b5e7f6ac1345d94d93fa890f325ae780ca6b4d2/msgraph/client.go#L448

This will need to change as the content-type header needs to be able to be set to an image format. I don't know how to determine what this will break?

Threpio avatar Feb 28 '23 14:02 Threpio

(Test failures unrelated)

manicminer avatar Jun 05 '24 22:06 manicminer