RF24 icon indicating copy to clipboard operation
RF24 copied to clipboard

Remove powerDown() from write command.

Open sourceperl opened this issue 10 years ago • 5 comments

Hi Maniacbug,

Thanks for your great job ! It's very useful for me.

I have some compatibility problem with Olimex MOD-24LR board and RF24 lib so i have to change the code.

Commit detail:

Remove powerDown() from write command. Now, we can use Power On/Off from user application. Necessary because XTAL startup time is not the same for every NRF board.PowerUp can take more than 1 ms (see 6.1.7 "Tpd2stdby" in nRF24L01+ product specification). For my test on Olimex MOD-24LR module delayMicroseconds(150) after PowerUp on startWrite is too short and write don't work. It's difficult to have an optimized value for every case. So, it's probably better to do this on user app.

Have a nice day, Loic Lefebvre

sourceperl avatar Sep 03 '13 16:09 sourceperl

Look at my fork. It has this optimization as will as new features. On Sep 3, 2013 11:16 AM, "l.lefebvre" [email protected] wrote:

Remove powerDown() from write command. Now, we can use Power On/Off from user application. Necessary because XTAL startup time is not the same for every NRF board.PowerUp can take more than 1 ms (see 6.1.7 "Tpd2stdby" in nRF24L01+ product specification). For my test on Olimex MOD-24LR module delayMicroseconds(150) after PowerUp on startWrite is too short and write don't work. It's difficult to have an optimized value for every case. So,

it's probably better to do this on user app.

You can merge this Pull Request by running

git pull https://github.com/sourceperl/RF24 master

Or view, comment on, or merge it at:

https://github.com/maniacbug/RF24/pull/27 Commit Summary

  • Remove powerDown() from write command.

File Changes

  • M RF24.cpp https://github.com/maniacbug/RF24/pull/27/files#diff-0(3)

Patch Links:

  • https://github.com/maniacbug/RF24/pull/27.patch
  • https://github.com/maniacbug/RF24/pull/27.diff

gcopeland avatar Sep 04 '13 05:09 gcopeland

Hi gcopeland,

MOD-24LR board work fine with your fork. Thanks a lot !

sourceperl avatar Sep 04 '13 20:09 sourceperl

Glad to hear it. Thanks for the feedback. On Sep 4, 2013 3:32 PM, "l.lefebvre" [email protected] wrote:

Hi gcopeland,

MOD-24LR board work fine with your fork. Thanks a lot !

— Reply to this email directly or view it on GitHubhttps://github.com/maniacbug/RF24/pull/27#issuecomment-23821601 .

gcopeland avatar Sep 05 '13 00:09 gcopeland

Greg,

U hv the best "fork" in town...

Send from iPhone4 ;-)

On 5 Sep 2013, at 08:47 AM, gcopeland [email protected] wrote:

Glad to hear it. Thanks for the feedback. On Sep 4, 2013 3:32 PM, "l.lefebvre" [email protected] wrote:

Hi gcopeland,

MOD-24LR board work fine with your fork. Thanks a lot !

— Reply to this email directly or view it on GitHubhttps://github.com/maniacbug/RF24/pull/27#issuecomment-23821601 .

— Reply to this email directly or view it on GitHub.

stanleyseow avatar Sep 05 '13 01:09 stanleyseow

Thanks man.

Can't wait until I have time to focus on my hobbies again. On Sep 4, 2013 8:32 PM, "Stanley Seow" [email protected] wrote:

Greg,

U hv the best "fork" in town...

Send from iPhone4 ;-)

On 5 Sep 2013, at 08:47 AM, gcopeland [email protected] wrote:

Glad to hear it. Thanks for the feedback. On Sep 4, 2013 3:32 PM, "l.lefebvre" [email protected] wrote:

Hi gcopeland,

MOD-24LR board work fine with your fork. Thanks a lot !

— Reply to this email directly or view it on GitHub< https://github.com/maniacbug/RF24/pull/27#issuecomment-23821601> .

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/maniacbug/RF24/pull/27#issuecomment-23838491 .

gcopeland avatar Sep 06 '13 03:09 gcopeland