react-native-expo-read-sms
react-native-expo-read-sms copied to clipboard
Typescript
Description
In this PR I changed the JS files to TS files and added type to make this lib more easy to use.
Fixes # (issue)
#29 #
Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [x] This change requires a documentation update
@YovelNehmady : Is this ready for review?
@maniac-tech: Yes.
@YovelNehmady can you also create a PR in the example application consuming these changes ?
This way we can test, and update the sample application too.
@maniac-tech Yes I can.
@maniac-tech Yes I can.
Lets do that then
@maniac-tech Yes I can.
Lets do that then
I am from Israel and we are currently at war so it will take me a little time to do this.
@maniac-tech Yes I can.
Lets do that then
I am from Israel and we are currently at war so it will take me a little time to do this.
Take your time, and most importantly be safe @YovelNehmady !
@maniac-tech would you like me to complete this? Having typescript would be very helpful while working on the frontend.
@maniac-tech would you like me to complete this? Having typescript would be very helpful while working on the frontend.
Sure!