react-native-expo-read-sms icon indicating copy to clipboard operation
react-native-expo-read-sms copied to clipboard

Typescript

Open YovelNehmady opened this issue 2 years ago • 10 comments

Description

In this PR I changed the JS files to TS files and added type to make this lib more easy to use.

Fixes # (issue)

#29 #

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] This change requires a documentation update

YovelNehmady avatar Sep 19 '23 10:09 YovelNehmady

@YovelNehmady : Is this ready for review?

maniac-tech avatar Sep 26 '23 06:09 maniac-tech

@maniac-tech: Yes.

YovelNehmady avatar Sep 26 '23 07:09 YovelNehmady

@YovelNehmady can you also create a PR in the example application consuming these changes ?

This way we can test, and update the sample application too.

maniac-tech avatar Oct 07 '23 12:10 maniac-tech

@maniac-tech Yes I can.

YovelNehmady avatar Oct 07 '23 12:10 YovelNehmady

@maniac-tech Yes I can.

Lets do that then

maniac-tech avatar Oct 16 '23 09:10 maniac-tech

@maniac-tech Yes I can.

Lets do that then

I am from Israel and we are currently at war so it will take me a little time to do this.

YovelNehmady avatar Oct 16 '23 10:10 YovelNehmady

@maniac-tech Yes I can.

Lets do that then

I am from Israel and we are currently at war so it will take me a little time to do this.

Take your time, and most importantly be safe @YovelNehmady !

maniac-tech avatar Oct 23 '23 14:10 maniac-tech

@maniac-tech would you like me to complete this? Having typescript would be very helpful while working on the frontend.

alokpant avatar Jan 31 '25 21:01 alokpant

@maniac-tech would you like me to complete this? Having typescript would be very helpful while working on the frontend.

Sure!

maniac-tech avatar Feb 08 '25 15:02 maniac-tech