hakuneko icon indicating copy to clipboard operation
hakuneko copied to clipboard

[Feature] Download novels as webpages instead of image format

Open xeolod opened this issue 1 year ago • 10 comments

Is your feature request related to a problem? Please describe.

  • Currently hakuneko downloads any novel chapters as an image format.
  • The novel chapters when zoomed in looks ugly (cause its an image and not a web page).
  • And the reading experience is awful. If doesn't feel right. But when the chapter is read from xhtml the reading experience is good.

Describe the solution you'd like

  • I would like it to download the novel chapters as xhtml instead of image format.

Describe alternatives you've considered

  • None

Context (please complete the following information):

  • Your current HakuNeko Version [rev. master@d1163e]

Additional context

xeolod avatar Dec 05 '23 05:12 xeolod

Already asked wont append in Hakuneko Maybe in Haruneko

MikeZeDev avatar Dec 05 '23 10:12 MikeZeDev

I did not find this source one in hakuneko issue, so is this a mistake?

xeolod avatar Dec 05 '23 10:12 xeolod

Not a mistake, see #6280, #242 in haruneko and #40 in haruneko.

zeoint avatar Dec 06 '23 05:12 zeoint

You linked everything so i dont have to explain much.

  • No need for duplicate issues so i closed this one
  • Planned in Haruneko
  • Wont add a complex feature like this in Hakuneko, no time. Unless a contributor does that maybe.

If my english isnt clear enough i am sorry, i am not a native speaker.

MikeZeDev avatar Dec 06 '23 07:12 MikeZeDev

Reopening to crosstrack in haru as I'm unsure if this feature will be done in haru before it gets merged into haku. Note to MrRabbit: We let feature requests in haku's repo if we are not sure we'll do it before we delete haru's repo (once it's mature and merged to haku's. Too much requests in haru's repo would be a nightmare.

Sheepux avatar Dec 08 '23 18:12 Sheepux

I see, my bad then :) Ill close this one then ? https://github.com/manga-download/hakuneko/issues/2987

MikeZeDev avatar Dec 08 '23 18:12 MikeZeDev

This rises many questions like how to make sure the layout is ok. Do we fetch the novel HTML and just save it as HTML? Not the whole page and we are tasked to remove stuff ? Or we may miss the CSS styles of the document, not talking about external CSS? What about the preview? If we let the preview as image how can we distinguish the Preview mode and the Downloading mode? Should we remove all scripts by default in fetched html? Since it will be saved as html script can be nasty.

MikeZeDev avatar Dec 11 '23 10:12 MikeZeDev

I suggest checking out webtoepub for reference.

Do we fetch the novel HTML and just save it as HTML?

  • Maybe saving it as xhtml would be better as it would be stricter.

Or we may miss the CSS styles of the document, not talking about external CSS?

  • I think CSS are not necessary.
  • I never saw any novel (like the one in the below video) use any CSS rules that matters.
  • CSS file of 3000+ chapters novel, after cleaning the CSS rules not used in the novel using calibre - CSS for entire novel.txt

What about the preview?

  • Download the preview chapter as xhtml (temporary OS directory) and displaying it would solve it?

zeoint avatar Dec 12 '23 05:12 zeoint

Download the preview chapter as xhtml (temporary OS directory) and displaying it would solve it?

I mean we display a picture made of the text right now.

  • A picture is harmless.
  • If the interface is made to display pictures if will require a rework to display html instead

MikeZeDev avatar Dec 12 '23 07:12 MikeZeDev

A picture is harmless.

Then picture it is for preview.

zeoint avatar Dec 12 '23 08:12 zeoint