google-actions-starter icon indicating copy to clipboard operation
google-actions-starter copied to clipboard

Published 20 hours ago • verified publisher icon manekinekko

Added tests.

Open dblock opened this issue 8 years ago • 5 comments

A starter should have tests so that people don't forget to write them and ship fewer broken apps :)

Note that package.json uses "@manekinekko/google-actions-server": "dblock/google-actions-server#tests" as this needs https://github.com/manekinekko/google-actions-server/pull/2 which returns the express instance from listen() to which we can send HTTP POSTs.

dblock avatar Feb 15 '17 18:02 dblock

Bump @manekinekko.

dblock avatar Feb 22 '17 18:02 dblock

Unfortunately this is now hitting https://github.com/actions-on-google/actions-on-google-nodejs/issues/16. And they don't seem to want tests :(

dblock avatar Feb 22 '17 20:02 dblock

what do you suggest?

manekinekko avatar Feb 22 '17 20:02 manekinekko

For now just wait till https://github.com/actions-on-google/actions-on-google-nodejs/pull/17 is merged and 1.0.8 is released.

dblock avatar Feb 22 '17 20:02 dblock

Maybe @manekinekko you can ping someone at Google about this, like @smishra2?

dblock avatar Mar 01 '17 15:03 dblock