Wassim Chegham

Results 182 comments of Wassim Chegham

@manfredsteyer > As Schematic Collections are distributed via npm packages, we could leverage the existing npm infrastructure Agreed. Although, this will depend on what DX we wanna have (simple query...

@vitaliy-bobrov I'm okay with that too as long as the search process can be done in a deterministic and consistent way ^^

@manfredsteyer I'm using this loader so webpack can load and bundle the HTML template files, when using `templateUrl`. Do you have another option in mind?

Oh. Right. That make sense in AOT. Do you have a PR ready?

@vitaly87 sorry about this delay. Did you managed to resolve your issue?

Are you able to send a PR for this? We'll review it together...

@MoLow here is a screenshot comparing all 3 scenarios: 1. current output (https://github.com/nodejs/node/issues/44040) 2. node-tap 3. changes from this PR I think we are good! WDYT? ![image](https://user-images.githubusercontent.com/1699357/181777132-ec37f8fc-21a2-4ea7-a2b7-f70e8e896a67.png)

@anonrig specs 14 state that subtests need to be terminated by a test point. ``` TAP version 14 # Subtest: subtest name

Thanks for investigating this @anonrig! I agree we should ignore the mocha report case (unless there is a requirement I am not aware of). @MoLow the upcoming built-in TAP parser...

I guess the answer is yes. The parser will need to implement both strategies. The current implementation will need some major refactoring but it's manageable. However, the current TAP 14...