Martin André

There recently was a lot of refactoring in security groups, and now the security group rules creation happens as part of the security group update. That said, the security group...

Indeed, this was automatically closed as completed because the related PR included the magic `Fixes` keyword. I'll re-open because we still don't have PUT.

I have found it very helpful, when working on controllers after we created the scaffolding tool, to have at least 2 separate commits: - the first one that just runs...

> @mandre do you have a clue why make-generate is failing? I have run locally a couple of times and it seems ok. Replacing the diff text manually makes sense?...

> > This seems very close to a merging state. Really nice work! I've noticed you made iterative commits, where you added new commits to address review comments. That's OK...

> @mandre @jtopjian can you think of a reason why we didn't have that already? If I were to guess, I'd say "no particular reason" other than we missed it...

Good catch, this is a mistake. It should be: ```go SecurityGroupRefs []KubernetesNameRef `json:"securityGroupRefs,omitempty"` ``` In practice, both `OpenStackName` and `KubernetesNameRef`'s underlying type is string, however they differ by their validations....

Unfortunately, merging this fix would require cutting a new major release as it touches the published API. We may want to group it with other non-backward compatible changes, FYI.

> Thanks a lot for the fix! FYI: I didn't assume you would have to fix it, I could have done it. I just needed a heads up first into...

> Can we also add Endpoint (https://docs.openstack.org/api-ref/identity/v3/#service-catalog-and-endpoints ) to the list of Keystone controllers? Absolutely! We have a student already working on services (https://github.com/k-orc/openstack-resource-controller/issues/429). Adding support for endpoints would be...