mandiant
emit number(0) for insn like "xor eax, eax"
closes #2622
Checklist
- [ ] No CHANGELOG update needed
- [ ] No new tests needed
- [X] No documentation update needed
@williballenthin , I have tested binexport2 for arch64 but could not find any binary with arm architecture. However, I am confident that it will work. But let know me if there is any present in the database. We should add a test for that too.
I think we could emit these features from the 'extract_insn_nzxor_characteristic_features' functions to avoid duplicate code.
I think we could emit these features from the 'extract_insn_nzxor_characteristic_features' functions to avoid duplicate code.
I think the extract_insn_nzxor_charateristic_features is its own particular route and we should try to emit these features from it. Instead, what we can do is abstract away their logic into new helper functions and use them in place of raw checking. Shall I change to that?
Interesting idea, can you show these changes for the vivisect extractor as an example?
Pro of the suggestion is a better separation, con is slightly more code.
@mr-tz , can you please review the example implementation? If you approve this, I can do the same for other backends too.
@mr-tz , can you please review the example implementation? If you approve this, I can do the same for other backends too.
@mr-tz ?
Reason: The previous commit contained a logical bug, fixed in this commit.
@williballenthin & @mr-tz , I have implemented the requested changes. Please review them whenever you are free. Also, please run the tests for binary ninja backend and let know me if you run into any issue.
@mr-tz @williballenthin, I've made the requested changes. Please review whenever you are free.
@mr-tz @williballenthin, can you please take a look at the changes that I have made whenever you are free and tell me if there is a need for further modifications?
@mr-tz @williballenthin, can you please take a look at the changes that I have made whenever you are free and tell me if there is a need for further modifications?
@mr-tz @williballenthin @mike-hunhoff ?