VM-Packages
VM-Packages copied to clipboard
VSCode Package not updating correct
What's the problem?
As noted here: https://github.com/mandiant/VM-Packages/pull/947#issuecomment-2030533590
VSCode versioning seems to be out of sync and there is also an issue preventing it from updating properly that I'm not sure is something in our control.
Attempting to perform the update correctly led to an issue with resolving chocolatey-core.extension >= 1.3.3
for some reason:
Steps to Reproduce
Change vscode.vm.nuspec
package to use 1.87.2
for vscode.install
. Maybe also want to change the version for the overall package (vscode.vm
) to be 1.87.2.20240402
Environment
Environment agnostic
Additional Information
No response
Detected by test suite
Yes
This is an important bug in our update script, good catch! @emtuls would you like to try to fix this issue? :smile:
I'll take a look
It is not a bug in the update scrip as the version is not out of sync. The dependency is not called the same as the package, which means our test suite doesn't consider it to be a metapackage (this also follows our documentation). Options:
- Change the version of this package to 0.0.0.DATE and not consider it a metapackage (similar to packages with a URL without version)
- Change the name of this package to
vscode.install.vm
so that it is considered a metapackage - Change the dependency to
vscode
insteadvscode.install
, which seems to just be a wrapper, so that the the package is considered a metapackage and has the same name.
If there nothing against it, I would go for option 3. @emtuls opinions?
The package doesn't fail to install for me locally and it is also not failing in the daily. Can you please add detailed instructions how to reproduce the chocolatey-core.extension
error?
@emtuls any updates on the error when installing this package? we still need to fix the version