VM-Packages icon indicating copy to clipboard operation
VM-Packages copied to clipboard

Hashcat Failure Due to Processor Check

Open MalwareMechanic opened this issue 1 year ago • 4 comments

The hashcat package will fail if the system's processor is not "GenuineIntel", see below:

https://github.com/mandiant/VM-Packages/blob/eac039ddb9852d3cc155a400895de4bebeb1ccfc/packages/hashcat.vm/tools/chocolateyinstall.ps1#L20-L26

However, the GitHub actions to test installation may use non-GenuineIntel processors and the package will fail. Since we cannot guarantee the processor type during the test installation, I propose we complete the installation and raise a warning to the user that their system does not support this tool due to a non-GenuineIntel processor.

This allows the test suite to recognize a successful installation and will reduce confusion as to why the package is failing.

@mandiant/commando-vm thoughts since this is mainly a Commando VM tool?

MalwareMechanic avatar Nov 10 '23 16:11 MalwareMechanic

linking #653

day1player avatar Nov 10 '23 16:11 day1player

I think the documentation may have changed since we last worked on this package. I'm ok with this as the requirements to run have apparently changed

day1player avatar Nov 10 '23 16:11 day1player

I'm thinking it through some more. I'm not sure we should preform a check -- simply install and let the user find out afterwards when they execute it that it fails. My thought process is that even if we generate a warning, the user will likely not see it (esp. in headless mode).

@mandiant/commando-vm thoughts?

MalwareMechanic avatar Nov 10 '23 22:11 MalwareMechanic

@Menn1s thoughts on this one?

day1player avatar Jan 02 '24 16:01 day1player