coref icon indicating copy to clipboard operation
coref copied to clipboard

Model structure redundancy

Open grig-guz opened this issue 4 years ago • 2 comments

Hi,

The span width embedding over here: https://github.com/mandarjoshi90/coref/blob/bd04f2e19b9dcc0b8bba848a335e4af3be50741c/independent.py#L379 is pretty much equivalent to the span embedding over there, since the width embedding is concatenated to other span embeddings and then passed through a linear layer: https://github.com/mandarjoshi90/coref/blob/bd04f2e19b9dcc0b8bba848a335e4af3be50741c/independent.py#L362 I am trying to reimplement your model in Pytorch, so I was just wondering if there is any rationale for using two sets of span width embeddings?

Thank you.

grig-guz avatar Aug 10 '20 05:08 grig-guz

Hi @grig-guz! I have also implemented this model using Pytorch but always have a performance gap of around 1.2 F1 scores with the official results reported on paper. How does your implementation go on? Maybe we could share some ideas and experiences with each other.

Fantabulous-J avatar Aug 13 '20 03:08 Fantabulous-J

Hi @Fantabulous-J, sure. I've got around 74 F1 on the dev set with Spanbert-Base, didn't run on the test set yet. My email is on my github page, you can write me there.

grig-guz avatar Aug 13 '20 04:08 grig-guz