youtube-dl-server icon indicating copy to clipboard operation
youtube-dl-server copied to clipboard

Add download history management and other improvements

Open nbr23 opened this issue 4 years ago • 18 comments

Hello,

Adding a few features and updating the UI slightly while trying to remain in the original spirit:

  • Add download history and download log recording and viewing
  • Update Dockerfile to pull static files and serve them locally
  • Add queue size viewer in UI
  • Simplify endpoints
  • Update readme to reflect changes made

Update 23/04/2020:

  • Add rough subtitles download support

Update 25/04/2020:

  • Merge @gallofeliz 's improvements (UI adds with detailed stats, as well as recording of pending jobs in the db)
  • Resume pending jobs recorded by @gallofeliz in the db
  • Refactor sqlite works, aiming to have a more thread safe implementation
  • Update bookmarklet examples in README

Update 10/05/2020:

  • Merge @eikevons adding downloading file listing and links
  • Add retry option in log view for failed jobs

Update 10/06/2020:

  • Add metadata fetching (without downloading) to be able to handle https://github.com/manbearwiz/youtube-dl-server/issues/65

Cheers!

nbr23 avatar Apr 15 '20 04:04 nbr23

Very good job :+1: Suggestion : Add in the "logs" list the pending ones. Else we don't know what is in the pending queue ; and other reason : if the service is stopped, I feel that we loose all our pendings :'(

gallofeliz avatar Apr 25 '20 17:04 gallofeliz

I did it in https://github.com/gallofeliz/youtube-dl-server ;)

gallofeliz avatar Apr 25 '20 17:04 gallofeliz

Looks great @gallofeliz, refactoring a bit and adding resume on start, I'll merge with my fork later today. I love the improved stats at the top right!

Cheers!

nbr23 avatar Apr 25 '20 22:04 nbr23

Merged, @gallofeliz, and resuming the pendings on start now. Thanks again!

nbr23 avatar Apr 26 '20 00:04 nbr23

Yes, it will be a great app :) I don't know Python so refactoring after me is good ahah !

Regards

gallofeliz avatar Apr 26 '20 08:04 gallofeliz

Hi,

I issue slow UI sometimes, I don't know why. I updated logs to put same colors than stats ; but probably put colors on status badges should be more "discret". I fixed main page height.

Regards

gallofeliz avatar Apr 26 '20 09:04 gallofeliz

Hi @gallofeliz do you have more details about the slowness you are seeing? Any specific actions that make it slow? I saw your message about interrupted running jobs causing issues, but can't find the comment anymore, did this end up being a non issue? Thanks for the cosmetic improvements!

nbr23 avatar Apr 26 '20 15:04 nbr23

Hi @nbr23,

I removed the comment about interrupted running job because I didn't reproduce it. For me the job was ended because youtube-dl said it in the cli logs but maybe it needs a lot of time to finish the encoding or to write to the disk.

About the slow, I will see.

gallofeliz avatar Apr 26 '20 16:04 gallofeliz

I tested again and I issued slow pages, not stats. I issued slow main page and then slow logs page, but after that, no more, even if I reboot the service, I disable chromium cache, I go to Firefox. It's like ... random !

Regards. Screenshot from 2020-04-26 18-32-53 Screenshot from 2020-04-26 18-33-16

gallofeliz avatar Apr 26 '20 16:04 gallofeliz

@gallofeliz ok weird, I have not seen any slownesses so far. I will keep an eye out. Regarding the job you thought had ended, it can indeed take a long time for the post download conversion with ffmpeg, so what you saw was most likely that, ffmpeg working in the background still.

I've updated the logs page a little to just show the color on the status and not the whole line. That should make it easier on the eye ;)

nbr23 avatar Apr 26 '20 18:04 nbr23

Yes good. I will stop to develop for the moment and begin to use :)

The next step for me is to be able to stop it correctly ... When I do CTRL-C, it doesn't stop. I need to do it 3 times. I don't know how to do, I tried exit(0) but without success.

Regards

gallofeliz avatar Apr 27 '20 08:04 gallofeliz

Is this still work in progress? any chance for merge?

fluential avatar Jun 12 '20 08:06 fluential

@fluential it is stable and can be merged

nbr23 avatar Jun 12 '20 19:06 nbr23

@manbearwiz can this be merged?

fluential avatar Jun 16 '20 19:06 fluential

??

fluential avatar Apr 14 '21 15:04 fluential

This is super dope... I've got the fork pulled and running great on my unRAID box. It'd be AMAZING to see this merged and given an official Community Apps release! 😁🤩

jcat4 avatar May 04 '21 05:05 jcat4

This is the best youtube downloader I've seen by far. Longing for the newer version with file size showing for finished download. one silly question would like check; Does docker with tag "yt-dlp" mean using yt-dlp while "latest" is using youtube-dl? Somehow I realized the performance for youtube-dl is not good lately, that's why I'm quite eager to use yt-dlp instead. Thanks.

williswschan avatar Sep 08 '22 16:09 williswschan

Does docker with tag "yt-dlp" mean using yt-dlp while "latest" is using youtube-dl?

That is correct yes!

nbr23 avatar Sep 08 '22 16:09 nbr23