middleman-search icon indicating copy to clipboard operation
middleman-search copied to clipboard

Update to Lunr 2.0.3

Open sn3p opened this issue 7 years ago • 5 comments

Closes https://github.com/manastech/middleman-search/issues/25

  • [x] Update to Lunr 2.0.3
  • [x] Implement new Lunr API
  • [ ] Automatic minification?

After implementing the new Lunr API changes all seems fine, and the specified pages are indexed. But after refreshing search.json in the browser was empty again.

@matiasgarciaisaia maybe you have some insights on what might be the problem?

sn3p avatar May 16 '17 08:05 sn3p

I am using this PR in production. So, hearty +1

gerwitz avatar Jul 07 '17 13:07 gerwitz

Then maybe the problem was with my setup, good to know 👍 Maybe this is production ready after all. @matiasgarciaisaia what do you think?

Before merging we might want to:

sn3p avatar Jul 16 '17 07:07 sn3p

@matiasgarciaisaia would you consider minifying lunr.js manually on every update for now?

If you don't mind we can get this PR merged 💃

sn3p avatar Sep 08 '17 14:09 sn3p

Please merge this. Searching is severely impaired using the old version.

westonganger avatar May 07 '18 21:05 westonganger

I hope someone from this Org merge this too 🙏

tnir avatar Jul 06 '22 05:07 tnir