Manuel Astudillo

Results 577 comments of Manuel Astudillo

It increases complexity and edge cases maybe an order of magnitude, which use case is so important that will require this functionality?

Yeah, I am aware of the theoretical cases, I mean a real-world case where this is needed and no simple workaround can be found. For instance, in your example above...

@ivnnv we can look into the issue. The first thing I would like to ask is if you could clean up the code, you are using some patterns that are...

@PlkMarudny I will bet there is some loop in your processor that is calling ```await job.updateProgress(0);``` non stop. The stream should be capped though, so we can fix that, but...

@PlkMarudny in the code you provide there is no queue adding jobs or anything like that. If you provide a complete minimal test case that exhibits the scenario we can...

This fix in this release(https://github.com/taskforcesh/bullmq/commit/d7cf6ea60830b69b636648238a51e5f981616d02) should avoid the update progress to not capping the stream. However I would make sure the issue with the unlimited amount of calls to updateProgress...

Well, since you did not provide the test case as asked I tried to resemble something based on your pieces to something like this: ```ts const IORedis = require("ioredis"); const...

Thanks for the PR. I wonder, when is copy_scripts.py supposed to be called?

I think if generating the scripts is necessary to make sure the tests are running with the latest lua script, it should be called in run_tests.sh. What do you think...

This is not needed. The underlying Redis connection is only closed if it is not "shared": https://github.com/taskforcesh/bullmq/blob/master/src/classes/redis-connection.ts#L297