mlibc icon indicating copy to clipboard operation
mlibc copied to clipboard

internal: use libsmarter

Open 64 opened this issue 2 years ago • 5 comments

See also managarm/libsmarter#4.

64 avatar Aug 05 '22 18:08 64

libsmarter's make_shared at least seems to call operator new.

64 avatar Aug 10 '22 13:08 64

Ah, okay. allocate_shared should do the same thing as make_shared but take an explicit allocator. We can just use that, then.

64 avatar Aug 10 '22 14:08 64

Why do we need this? The PR does not immediately add a usecase for libsmarter so I'm curious what you want to use it for.

Geertiebear avatar Nov 22 '22 09:11 Geertiebear

IIRC I wanted to use it for refcounting stuff in ld.so so that we don't e.g leak memory when we destroy threads. This PR needs a bit of updating as per my last comment, though

64 avatar Nov 23 '22 21:11 64

Alright, but then at leas the use-case is clear, thanks.

Geertiebear avatar Nov 24 '22 09:11 Geertiebear