lai icon indicating copy to clipboard operation
lai copied to clipboard

Use standard stdnoreturn.h

Open Neptune650 opened this issue 3 years ago • 2 comments

Neptune650 avatar Jan 18 '22 03:01 Neptune650

The problem I see with both this PR and #111 is that stdnoreturn.h and stdalign.h were only defined in C11, while lai's meson.build does not specify a minimum C version. As there is currently (at least to my knowledge) no minimum required version and setting custom flags is encouraged (i.e. use lai as a meson subproject), merging these PRs would introduce an implicit requirement that hurts portability. Note that I am not completely sure whether something else C11-specific is already in the codebase, though.

no92 avatar Jan 18 '22 03:01 no92

I'm pretty sure using standard versions of them is much better than using non-standard compiler specific alternatives, and I closed the stdalign.h pull request because it isn't possible to use alignas in typedef.

Neptune650 avatar Jan 18 '22 03:01 Neptune650